zoon icon indicating copy to clipboard operation
zoon copied to clipboard

par - Modules can leave it a mess

Open AugustT opened this issue 8 years ago • 1 comments

Some modules, like PrintMap, change the values of par() without resetting them at the end. This is naughty and could be caught in module tests (check original par values against values returned after the module is run). We could also force them to be returned to defaults by capturing the values at the beginning of the workflow and resetting them at the end.

AugustT avatar Feb 10 '17 12:02 AugustT

Yes think getting workflow to do that is sensible.

As always, low bar to module contribution is useful. Even though getting modules to catch and reset par isn't that hard, it's more that we don't want the documentation for what modules must do to be long.

Having to read the whole CRAN guidelines just in case there's something you hadn't thought of that's not allowed is a pain for example. We want to avoid that.

timcdlucas avatar Feb 10 '17 12:02 timcdlucas