front-end-monorepo icon indicating copy to clipboard operation
front-end-monorepo copied to clipboard

lib-user: Fix MembersList paginationProps property assignment

Open mcbouslog opened this issue 4 months ago • 1 comments

Package

  • lib-user

Describe your changes

  • fix the paginationProps properties numberItems and step, which were not being defined from membershipsData.meta properly, as it was missing the memberships property within the meta object
  • add handlePageChange function for pagination page change
  • note these changes are in-line with MyGroupsContainer pagination

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX? n/a
  • What user actions should my reviewer step through to review this PR?
    • see bug at ⚠️ actual user group 2533715 , with admin mode enabled, click the "Manage Group," note the list of members does not paginate
    • locally, similar steps as above, at https://local.zooniverse.org:3000/groups/2533715?start_date=2024-10-04&env=production , note the list of members does paginate
  • Which storybook stories should be reviewed? n/a
  • Are there plans for follow up PR’s to further fix this bug or develop this feature? no

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes. PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • [ ] Tests are passing locally and on Github
  • [ ] Documentation is up to date and changelog has been updated if appropriate
  • [ ] You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • [ ] FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • [ ] FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • [ ] All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • [ ] Can submit a classification
  • [ ] Can sign-in and sign-out
  • [ ] The component is accessible

Bug Fix

  • [ ] The PR creator has listed user actions to use when testing if bug is fixed
  • [ ] The bug is fixed
  • [ ] Unit tests are added or updated

mcbouslog avatar Oct 10 '24 20:10 mcbouslog