obsidian-export icon indicating copy to clipboard operation
obsidian-export copied to clipboard

Filenames with spaces don't render correctly on GitHub pages

Open jcolson opened this issue 3 years ago • 4 comments

filenames with spaces are converted to links with %20 in them, however kramdown/etc does not seem to properly recognize this and does not convert these links to proper html links, instead it keeps the .md extention, which fails to work (404) on github pages.

EDIT: I tested manually replacing the %20 with an actual space, and github's kramdown now renders it properly. (maybe this could be an option, as %20 "should" work (in my opinion) everywhere, github just has an issue maybe?)

jcolson avatar Jan 17 '22 17:01 jcolson

It would not be too difficult to offer different "link encoding profiles" optimized for different markdown engines, with the current set being the default.

If you let me know which characters should, and which should not, be encoded to play nice with Kramdown/Jekyll, I'd be happy to implement this.

zoni avatar Jan 17 '22 18:01 zoni

Also, was this on Jekyll/GitHub pages, or just GitHub's rendering of Markdown files when you browse a repository? Is the behavior different or the same for those?

zoni avatar Jan 17 '22 18:01 zoni

It would not be too difficult to offer different "link encoding profiles" optimized for different markdown engines, with the current set being the default.

If you let me know which characters should, and which should not, be encoded to play nice with Kramdown/Jekyll, I'd be happy to implement this.

the only thing i ran into was the %20 ... which, remarkably, I didn't see too much consternation about from users; my google skills may be lacking.

jcolson avatar Jan 17 '22 21:01 jcolson

Also, was this on Jekyll/GitHub pages, or just GitHub's rendering of Markdown files when you browse a repository? Is the behavior different or the same for those?

specifically github pages ... i haven't tried standard github rendering of the results of an export

jcolson avatar Jan 17 '22 21:01 jcolson