zonemaster icon indicating copy to clipboard operation
zonemaster copied to clipboard
verified publisher icon zonemaster

Updates Basic01

Open matsduf opened this issue 3 years ago • 7 comments

Purpose

This is an update of the test case.

  • Follow the test case template.
  • Use and refer to "DNS Query and Response Defaults".
  • Better capture all possible situations.
  • Handle DNAME in reasonable way
    • #1075
    • #472

Context

Today Zonemaster ignores DNAME which means that domains that are delegated using DNAME instead of NS will not be discovered. Issues #1075 and #472 ask for a better handling of DNAME.

The test case was updated by PR #642 but that update was never implemented, see issue zonemaster/zonemaster-engine#568.

Changes

Specification of test case Basic01.

How to test this PR

This change is documentation only, but must result in an update of the implementation.

matsduf avatar Jul 14 '22 13:07 matsduf

@mattias-p @pnax @tgreenx Please re-review.

matsduf avatar Aug 24 '22 04:08 matsduf

Oh. I didn't mean to submit these last few comments a review. I must have clicked the wrong button. I may return to the Terminology section later with a proper review.

mattias-p avatar Aug 24 '22 09:08 mattias-p

It seems I have no control over when Github submits my review comments.

mattias-p avatar Aug 24 '22 10:08 mattias-p

Steps 5, 6 and 7 are kind of big and doing lots of stuff. Would you consider prefixing each of them with a short comment, just a few words that captures the gist of them without going into any details? That would be helpful for people who want to (re)familiarize themselves with the procedure, and it would help those already familiar with navigation.

I added text. Please review.

matsduf avatar Aug 25 '22 02:08 matsduf

@mattias-p, @pnax and @tgreenx, please re-review.

Please do "resolve conversation" when possible.

matsduf avatar Aug 25 '22 02:08 matsduf

@mattias-p and @pnax, do you have any further comments on this PR?

matsduf avatar Sep 13 '22 06:09 matsduf

@mattias-p, please do "resolve conversation" where you have no further comments or questions.

matsduf avatar Sep 13 '22 11:09 matsduf

@pnax and @tgreenx, please re-review. I rebased and added minor fixes.

matsduf avatar Feb 13 '23 15:02 matsduf

@tgreenx, can you implement this too? Can I merge this too?

matsduf avatar Feb 14 '23 09:02 matsduf

@tgreenx, can you implement this too? Can I merge this too?

Yes, go ahead

tgreenx avatar Feb 14 '23 10:02 tgreenx

@tgreenx, thanks. Issue https://github.com/zonemaster/zonemaster-engine/issues/1194 has been created.

matsduf avatar Feb 14 '23 21:02 matsduf