zonemaster-gui icon indicating copy to clipboard operation
zonemaster-gui copied to clipboard

History page discussion

Open hannaeko opened this issue 1 year ago • 3 comments

We have a few issues (and one PR) talking about the history.

So far the complaints are

  • the history modal is not closed we selecting a test,
  • but what if we want to jump from test to test quickly (#242),
  • the history modal is not refreshed when a new test is created (#412),
  • we can't query the history without first accessing a test result (#333).

I suggest we take the approach of having a "History" page, that the result page can link to. On this page we could have the list of previous tests, and when we click on one, we have the test result show below the list. This way we avoid the modal issue (screen reader user are informed that a new test result has been loaded using a live region), have a dedicated page to lookup a domain history, the result page and history page being two different page we avoid the refresh issue.

What do you think?

hannaeko avatar Nov 27 '23 16:11 hannaeko

I think it sounds fine.

matsduf avatar Nov 28 '23 10:11 matsduf

Same, sounds good to me.

I could see a heat map in such an History page, it is usually visually helpful.

tgreenx avatar Nov 29 '23 15:11 tgreenx

I agree. I like the idea of having a proper history page.

mattias-p avatar Nov 30 '23 07:11 mattias-p