zonemaster-engine icon indicating copy to clipboard operation
zonemaster-engine copied to clipboard

Published 20 hours ago • verified publisher icon zonemaster

Fixes broken handling of return codes from ASN lookup

Open matsduf opened this issue 1 year ago • 3 comments

Purpose

The the test case specification of CONNECTIVITY03 it specified that certain errors in the lookup responses should be handled by the test case. That was halfway implemented. The return codes were never sent to the test case code. This PR fixes that.

Changes

How to test this PR

Erroneous response from a ASN database must be created. Unit tests will be added to this PR.

matsduf avatar Mar 06 '23 10:03 matsduf

The return codes were never sent to the test case code.

They were before I implemented #1207. I see I forgot to return $ret_code. This looks good to me. If you think it's ready and mark it as such I'll approve it.

ghost avatar Mar 06 '23 15:03 ghost

They were before I implemented #1207. I see I forgot to return $ret_code. This looks good to me. If you think it's ready and mark it as such I'll approve it.

I will try to do some testing first, and then I will make it ready.

matsduf avatar Mar 06 '23 18:03 matsduf

@matsduf I think this draft can be closed. It was handled by #1219 (in v2023.1).

tgreenx avatar Nov 07 '23 10:11 tgreenx