zonemaster-engine icon indicating copy to clipboard operation
zonemaster-engine copied to clipboard

Encapsulate DNS request behavior in a method

Open mattias-p opened this issue 3 years ago • 0 comments

A discussion started in https://github.com/zonemaster/zonemaster-engine/pull/1109#discussion_r932394549 about adding a method for making DNS requests that encapsulates the default TC fallback behavior. I'm creating this issue to avoid stalling that PR on a discussion that's important but not central to the PR.

Summarizing that discussion, the idea was put forth to create a method that encapsulates the default way we make DNS requests. And for each behavior in the specifications that deviate from the default, the caller should be able to easily override that in the method parameters. (Possibly it could be a DNS request API that consists of more than one method.)

We should deprecated and remove all properties from the Profile that correspond to LDNS flags that the DNS request method wants to set/clear. This way we avoid confusing interactions between the DNS request API and the Profile settings.

mattias-p avatar Aug 15 '22 14:08 mattias-p