node-open-mining-portal icon indicating copy to clipboard operation
node-open-mining-portal copied to clipboard

Adding pool on the fly

Open miningpoolhub opened this issue 10 years ago • 33 comments

Hi Can I add pool on the fly?

When I need to add coin, the codes seems like whole stratum node needs to be restarted. Affecting all other coins looks like problem to real productions.

Anyway.. what a awesome works!!! Really Great!!!

miningpoolhub avatar Mar 08 '14 09:03 miningpoolhub

This would be a great feature. It can be implemented once we get the frontend developed, and the admin page of the frontend developed :)

zone117x avatar Mar 13 '14 21:03 zone117x

This is huge! I have to disconnect my entire network to add a coin right now!

mculp avatar Apr 11 '14 05:04 mculp

+1

iangcarroll avatar Apr 12 '14 03:04 iangcarroll

forever restart init.js disconnect all ppl ? Or its enough fast for do the job ?

mineoncloud avatar Apr 12 '14 15:04 mineoncloud

yes it disconnects all workers On Apr 12, 2014 10:59 AM, "bayo31" [email protected] wrote:

forever restart init.js disconnect all ppl ? Or its enough fast for do the job ?

— Reply to this email directly or view it on GitHubhttps://github.com/zone117x/node-open-mining-portal/issues/5#issuecomment-40284174 .

mculp avatar Apr 12 '14 16:04 mculp

We tryed adding pools on the fly by adding there configs but with the coins off started the portal and from there it throws an errer about the coins RPC Responce, but did seem to load up and allow pople to mine there coins, to actually add the coin for starting we jsut started the new coin (configs already loaded rememer) and waited for it to pool.

Been trying out lots of crazy ideas with this since a customer asked for it.

Devs need a pat on the back such a breeeeze to work with

LiveChains avatar May 07 '14 10:05 LiveChains

I have almost finished this feature. I also was pointed to https://www.bountysource.com/issues/1588495-adding-pool-on-the-fly so if anyone would like to contribute feel free to do so, if not, after i have polished the code i will submit PR.

For now, i have this working:

  • Add new file pool_configs/new_pool_name.json
  • Send node scripts/cli.js reloadpool new_pool_name
  • New stratum instance is spawned, supporting clustering if enabled.
  • New workers are auth'ed and can start mining

What needs to be polished:

  • Profit switching to use new coin
  • Payouts to new coin.

nicoschtein avatar May 13 '14 16:05 nicoschtein

UPDATE

For now, i have this working:

  • Add new file pool_configs/new_pool_name.json
  • Send node scripts/cli.js reloadpool new_pool_name
  • New stratum instance is spawned, supporting clustering if enabled.
  • New workers are auth'ed and can start mining
  • Profit switching to use new coin (new)

What needs to be polished:

  • Payouts to new coin.

Also a bounty was met, that was quick, Thanks mineoncloud All other backers still welcome to donate :+1:

nicoschtein avatar May 13 '14 23:05 nicoschtein

UPDATE

For now, i have this working:

  • Add new file pool_configs/new_pool_name.json
  • Send node scripts/cli.js reloadpool new_pool_name
  • New stratum instance is spawned, supporting clustering if enabled.
  • New workers are auth'ed and can start mining
  • Profit switching to use new coin
  • Payouts to new coin. (new)

What needs to be added:

  • Update frontend to show new coin stats

All other backers still welcome to donate :+1:

nicoschtein avatar May 14 '14 18:05 nicoschtein

Looking forward to it! -icecube45 ($50 Backer)

icecube45 avatar May 15 '14 05:05 icecube45

Nice.— Sent from Mailbox

On Thu, May 15, 2014 at 1:01 AM, icecube45 [email protected] wrote:

Looking forward to it!

-icecube45 ($50 Backer)

Reply to this email directly or view it on GitHub: https://github.com/zone117x/node-open-mining-portal/issues/5#issuecomment-43168809

iangcarroll avatar May 15 '14 05:05 iangcarroll

Ping me when all done and when we can start test !!!

Mineoncloud.

mineoncloud avatar May 15 '14 10:05 mineoncloud

Should be ready to test now. Will submit PR. I need to rebase my branch before I can submit PR... Won't take that long...

nicoschtein avatar May 16 '14 13:05 nicoschtein

@miningpoolhub @mineoncloud @icecube45 PR #211 is up. Please test, it should work fine, but do it with test pools just in case...

nicoschtein avatar May 16 '14 14:05 nicoschtein

Has anyone tested #211 already?

nicoschtein avatar May 17 '14 21:05 nicoschtein

I go test today ! But one thing is to add this function in admin tabs too .

mineoncloud avatar May 19 '14 16:05 mineoncloud

Sure, as soon as this is confirmed to work, I can try to call cli from admin section. On May 19, 2014, at 1:22 PM, mineoncloud [email protected] wrote:

I go test today ! But one thing is to add this function in admin tabs too .

— Reply to this email directly or view it on GitHub.

nicoschtein avatar May 19 '14 16:05 nicoschtein

Just add first pool with this functions report = block count = ok payout for fees = ok stats = ok for now payout for worker waiting confirm but all look good. Also any error in log for now.

mineoncloud avatar May 19 '14 17:05 mineoncloud

All work well on my side right now !! Add , payout , fees ( I just dont test multipool switch because dont use it atm ) !! I have also try disable pool ( turn enabled to false + reload it ) and it work.

mineoncloud avatar May 19 '14 19:05 mineoncloud

So? Does this work for the others too?

nicoschtein avatar May 20 '14 14:05 nicoschtein

Can this be merged already? It will be easier for me so I can rebase to master with this merged. Will also help with #214

nicoschtein avatar May 25 '14 16:05 nicoschtein

This function is not working for me :(

scorpio18 avatar May 27 '14 21:05 scorpio18

What is wrong ? I assume you have pulled my PR to test this, since this has not been merged yet... It won't work in a normal installation...

On May 27, 2014, at 6:02 PM, scorpio18 [email protected] wrote:

This function is not working for me :(

— Reply to this email directly or view it on GitHub.

nicoschtein avatar May 27 '14 21:05 nicoschtein

so that why is not working , i have seen on my nomp folder and i tried on my nomp pool :) Sry

scorpio18 avatar May 27 '14 21:05 scorpio18

Ok that explains it, don't worry!

I'm waiting for repo owner to merge this, or other users to report any errors, I thinks it works fine. As soon as this is confirmed to work and merged I will start with the other issue for removing and restarting a pool after modifying it.

On May 27, 2014, at 6:32 PM, scorpio18 [email protected] wrote:

so that why is not working , i have seen on my nomp folder and i tried on my nomp pool :) Sry

— Reply to this email directly or view it on GitHub.

nicoschtein avatar May 27 '14 22:05 nicoschtein

@miningpoolhub @zone117x @mineoncloud So, can we merge #211 or let me know what's needed so I can continue working on CLI?

nicoschtein avatar May 31 '14 17:05 nicoschtein

For me its good ! Why this is not yet merged ??

mineoncloud avatar Jun 02 '14 10:06 mineoncloud

make it - -

mrzeta avatar Jun 04 '14 06:06 mrzeta

@mrzeta I did not understand what you meant.. @mineoncloud I think that since repo owner did not merge this #211 at the time, it has now outdated code in it....... for some reason another PR got merged before this one. Please @zone117x let me know if and what is needed for the rebase. Thanks!

nicoschtein avatar Jun 10 '14 00:06 nicoschtein

When starting pool on the fly, the public key was not added to the drop down list to convert public key to importable key for the added pool.

sigwo avatar Jun 13 '14 10:06 sigwo