node-multi-hashing icon indicating copy to clipboard operation
node-multi-hashing copied to clipboard

Node-Multi-hashing - Node .10 to 8.x

Open krisklosterman opened this issue 7 years ago • 7 comments

I've attempted to update Node-Multi_hashing to compile in 8.1.3 using Nan. @zone117x

https://github.com/krisklosterman/node-multi-hashing/commit/fcd8547d53db46297510f45a6e5bbc549fd1e039

I was using mac-os to compile and got it to compile with only warnings about un-used functions. Scrypt-Jane needs work as it has errors about the assembly on Mac-OS, so I commented it out for now. Others more familiar with it please take a look.

This still could use some work, as I am no expert at writing add-on's for node

I will test today to see if it compiles with being included with node-stratum

krisklosterman avatar Jul 06 '17 12:07 krisklosterman

I can't get this to pull into node-stratum-pool.... tried changing the dep repo, tried adding it as a local repo, always gives me errors...

krisklosterman avatar Jul 06 '17 13:07 krisklosterman

Got it to pull into node-stratum-pool, removed a comment from the package.json

krisklosterman avatar Jul 06 '17 15:07 krisklosterman

got it to compile with nomp also, waiting to test hashing functionality with nomp with updated version

krisklosterman avatar Jul 06 '17 16:07 krisklosterman

Hey check out zone117x/node-cryptonote-pool#183 and zone117x/node-multi-hashing#42 with everything converted to nan and building on all current node LTS. https://travis-ci.org/PhearZero/node-multi-hashing

PhearZero avatar Aug 13 '17 10:08 PhearZero

My fork is updated and tested to version 8.3.X, I am turning up a production pool here in the next week with my fork, will hopefully be a true test against the updates to node 8.3.x

krisklosterman avatar Aug 13 '17 11:08 krisklosterman

My fork is working good, the only issue is the c code for scryptjane is not compiling, its disabled at this time. I am also going to work in the future on getting equihash supported.

krisklosterman avatar Jan 08 '18 12:01 krisklosterman

@krisklosterman thanks for all of the work you've done on this, but in the end I used @PhearZero's fork. Your commit history pretty messy and it's very hard to know what exactly has been done, and from the changes I saw in the diffs of a few commits, it looks like a lot of unnecessary changes have been made. Since there are no unit tests, it's hard to know whether the original functionality is still intact. Please please use a working branch for your changes and rebase out the useless commits when you're finalising everything.

Phear's fork looks great, the only changes made are the Nan ones (the only ones required to migrate to newer versions of node). @ayoubserti made basically the same changes in his fork but also altered the packages details and created a new npm module so it's easier to branch from Phear's fork.

I've fixed Windows compilation on my fork, and I've added Node 8 to Travis and also included a run on Appveyor.

codebling avatar Jan 08 '18 20:01 codebling