node-cryptonote-pool icon indicating copy to clipboard operation
node-cryptonote-pool copied to clipboard
verified publisher icon zone117x

Improve performance of redis command queue - #238

Open phenomax opened this issue 8 years ago • 2 comments

This PR makes a first step, solving the performance issues adressed in #238 by using the redis SCAN command instead of the KEYS command, which does not block the main queue.

Taken from redis documentation

Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout. Don't use KEYS in your regular application code.

phenomax avatar Jan 11 '18 23:01 phenomax

Thanks for identifying this. I'm not sure about the arbitrary count limit. Could we make it iterate over scan commands until empty as suggested here https://stackoverflow.com/a/33167701 ?

zone117x avatar Jan 14 '18 08:01 zone117x

Hey! I also thought about that, but using a very high count limit does not affect performance at all. We also would have to send the commands multiple times (until we got a full iteration), instead of just using one command. So afaik going with a high count value is fine.

phenomax avatar Jan 14 '18 19:01 phenomax