diplicity icon indicating copy to clipboard operation
diplicity copied to clipboard

Open up requests for non logged in requests

Open zond opened this issue 4 years ago • 6 comments

Where we don't NEED a login we shouldnt require one

zond avatar May 02 '20 14:05 zond

On the other hand - since we are actually disseminating personal information (like people's avatar pictures, and so on), I kind of like it that we require the viewer to also be logged in. It feels a bit less creepy if "only members can see the member list", so to speak.

@tttppp, @JorenC, what do you think?

zond avatar May 02 '20 18:05 zond

Also see https://github.com/zond/dipact/issues/121

zond avatar May 02 '20 18:05 zond

I certainly think that viewing the map, orders, etc. should be possible without logging in. Probably even viewing public messages. In fact I think it would make sense to open everything up, given that a user just needs a Google account to see this information currently and so it's basically already publicly available.

tttppp avatar May 05 '20 06:05 tttppp

It's publically available, but not easy to scrape, which is a big difference.

But yeah, the difference is subtle.

zond avatar May 05 '20 06:05 zond

I don't think it's a major issue. If anything, you could hide the player names and avatars if someone is not logged in?

I'm more concerned that someone is logged out (e.g. when the app gets updated) and then uses the link to enter the game, doesn't realise he is logged out and doesn't realise why he needs to log in again - there needs to be a clear "log in" action

JorenC avatar May 05 '20 06:05 JorenC

Yeah, the UX has to signal pretty clearly what's happening.

zond avatar May 05 '20 06:05 zond