ICSim icon indicating copy to clipboard operation
ICSim copied to clipboard

Published 20 hours ago • verified publisher icon zombieCraig

PSA support

Open cristiklein opened this issue 3 years ago • 5 comments

Added support for speed (and codes for RPM) as reverse engineered on my Peugeot 307 SW 2007, as well as support for metric units (km/h).

cristiklein avatar Apr 28 '21 13:04 cristiklein

@cristiklein This looks very cool. Just looking over the code changes I think this will be a fairly straightforward merge. Looking forward to testing it out! Thanks!

zombieCraig avatar Apr 28 '21 20:04 zombieCraig

@cristiklein So I don't see the -m psa support for controls.c just for icsim.c Did you forget to add that?

zombieCraig avatar Apr 28 '21 21:04 zombieCraig

@zombieCraig I'm not really using controls.c. I'm rather interested in replaying CAN-BUS messages via canplayer. Is that a blocker for accepting this PR?

cristiklein avatar Apr 28 '21 21:04 cristiklein

Hmmm, I see. I don't know that it's a blocker but if you were to add the same switch to controls.c you would be able to use a game controller (or whatever) to send packets to your vehicle. So you could test acceleration, etc on a test bench or what not. It would make the patch more complete but I don't know that it's a blocker.

zombieCraig avatar Apr 29 '21 02:04 zombieCraig

Hi. I found some times to add the psa model to controls too. It worked for me, but PTAL.

cristiklein avatar Apr 29 '21 11:04 cristiklein