Issue #332 - Uninstalling all older gems when autoupdating

[emilianodellacasa]

In order to solve issue #332 I modified the code to execute a command to delete all older versions of Zold when auto updating

[0crat]

Job #493 is now in scope, role is REV

[0crat]

@yegor256/z everybody who has role REV is banned at #493; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #493; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

This pull request #493 is assigned to @sergeykutsko/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[codecov-io]

Codecov Report

Merging #493 into master will decrease coverage by 0.31%. The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #493      +/-   ##
=========================================
- Coverage   33.42%   33.1%   -0.32%     
=========================================
  Files          63      62       -1     
  Lines        2941    2945       +4     
=========================================
- Hits          983     975       -8     
- Misses       1958    1970      +12

Impacted Files	Coverage Δ
lib/zold/commands/node.rb	19.13% <0%> (-0.52%)	:arrow_down:
lib/zold/wallet.rb	39.8% <0%> (-2.47%)	:arrow_down:
lib/zold/txns.rb	52.63% <0%> (-2.37%)	:arrow_down:
lib/zold/node/front.rb	34.72% <0%> (-2.1%)	:arrow_down:
lib/zold/node/nodup_entrance.rb	30.3% <0%> (-2.05%)	:arrow_down:
lib/zold/amount.rb	50% <0%> (-1.86%)	:arrow_down:
lib/zold/commands/propagate.rb	28% <0%> (-1.79%)	:arrow_down:
lib/zold/key.rb	37.83% <0%> (-1.64%)	:arrow_down:
lib/zold/commands/diff.rb	35% <0%> (-1.59%)	:arrow_down:
lib/zold/patch.rb	12% <0%> (-1.16%)	:arrow_down:
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6bc8a0...dba3c85. Read the comment docs.

[SergeyKutsko]

@yegor256 I think it ready to go.

[0crat]

@sergeykutsko/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[SergeyKutsko]

@egor256 take a look!

28 окт. 2018 г. 10:44 AM пользователь "Zerocrat" [email protected] написал:

@SergeyKutsko https://github.com/SergeyKutsko/z https://www.0crat.com/u/sergeykutsko this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8 http://www.zerocracy.com/policy.html#8. Read this http://www.yegor256.com/2014/04/13/no-obligations-principle.html and this http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html, please.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zold-io/zold/pull/493#issuecomment-433687016, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZ6ZsvTme-jaFeUkLEbzD4huH2EsyuHks5upW5-gaJpZM4Xcqh3 .

[yegor256]

@emilianodellacasa see above

[emilianodellacasa]

@yegor256 All issues have been addressed

[yegor256]

@emilianodellacasa see above

[emilianodellacasa]

@yegor256 see my comments above

[SergeyKutsko]

@emilianodellacasa @yegor256 So what we need update to get this task merged?

[emilianodellacasa]

@yegor256 When I uninstall zold gem, shall I also uninstall zold-score.

Does zold-score auto-updates as well together with zold?

[emilianodellacasa]

@SergeyKutsko I am waiting for some comments from @yegor256

[yegor256]

@emilianodellacasa I'm not sure. How it works in Ruby?

[emilianodellacasa]

@yegor256 Actually, zold-score should auto update as well, so it will be better to uninstall that gem as well before reinstalling zold (and, consequently, zold-score)