zold icon indicating copy to clipboard operation
zold copied to clipboard

Fix zold help formatting #320

Open botanicus opened this issue 6 years ago • 11 comments

#320

Please note that the squiggly heredoc has been introduced only as recently as in Ruby 2.3.

Travis should be fine as soon as we upgrade our Ruby version, part of #306. CodeClimate hopefully as well.

botanicus avatar Jul 03 '18 19:07 botanicus

@0crat wait

botanicus avatar Jul 03 '18 19:07 botanicus

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@6ac9e0a3-eadb-45bf-b051-800033971ed4, thread: pool-388-thread-1
com.zerocracy.farm.sync.SyncProject[77] java.lang.IllegalStateException: Failed to acquire "claims.xml" in "CAZPZR9FS" in 2min: 0d35431ea14f/13min/0/1/true/false by AsyncFlush-4

0.24.9: Issue: zold-io/zold#338, Comment: 402271384

0crat avatar Jul 03 '18 19:07 0crat

@rultor merge

yegor256 avatar Jul 04 '18 08:07 yegor256

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor avatar Jul 04 '18 09:07 rultor

@rultor merge

@botanicus @yegor256 Oops, I failed. You can see the full log here (spent 5min)

(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
          Usage: zold pay wallet target amount [details] [options]
               ^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:45:16: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tCOLON
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
          Where:
               ^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:47:16: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tIDENTIFIER
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
              'target' is the beneficiary (either wallet ID or invoice number)'
               ^^^^^^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:48:24: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tIDENTIFIER
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
              'amount' is the amount to pay, in ZLD, for example '14.95'
                       ^^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:48:46: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token kIN
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
              'amount' is the amount to pay, in ZLD, for example '14.95'
                                             ^^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:48:49: \u001b[31mE\u001b[0m: Lint/Syntax: dynamic constant assignment
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
              'amount' is the amount to pay, in ZLD, for example '14.95'
                                                ^^^
\u001b[36mlib/zold/commands/pay.rb\u001b[0m:49:25: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tIDENTIFIER
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
              'details' is the optional text to attach to the payment
                        ^^
\u001b[36mlib/zold/commands/calculate.rb\u001b[0m:38:20: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tLSHFT
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
        o.banner = <<~HELP.chomp
                   ^^
\u001b[36mlib/zold/commands/calculate.rb\u001b[0m:39:16: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tCOLON
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
          Usage: zold score [options]
               ^
\u001b[36mlib/zold/commands/remote.rb\u001b[0m:51:20: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tLSHFT
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
        o.banner = <<~HELP.chomp
                   ^^
\u001b[36mlib/zold/commands/remote.rb\u001b[0m:52:16: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tCOLON
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
          Usage: zold remote <command> [options]
               ^
\u001b[36mlib/zold/commands/remote.rb\u001b[0m:55:22: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tIDENTIFIER
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
                Show all registered remote nodes
                     ^^^
\u001b[36mlib/zold/commands/remote.rb\u001b[0m:65:61: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tIDENTIFIER
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
                Pick a random remote node as a target for a bonus awarding
                                                            ^^^^^
\u001b[36mlib/zold/commands/remote.rb\u001b[0m:71:67: \u001b[31mE\u001b[0m: Lint/Syntax: unexpected token tNL
(Using Ruby 2.2 parser; configure using \u001b[33mTargetRubyVersion\u001b[0m parameter, under \u001b[33mAllCops\u001b[0m)
                Check each registered remote node for availability \u001b[33m...\u001b[0m
                                                                  

113 files inspected, \u001b[31m70 offenses\u001b[0m detected
RuboCop failed!
container 6ac02a1829d7bc18f6bdacbcf8b65e9ac4bf30d25d124e576081a8e239553132 is dead
Wed Jul  4 11:08:52 CEST 2018

rultor avatar Jul 04 '18 09:07 rultor

@yegor256 status summary:

This is not to be merged yet as the checks failed. They should be OK as soon as we upgrade our Ruby in #306.

For that reason I wanted 0crat to wait, but he’s refusing. I reported the bug.

botanicus avatar Jul 04 '18 17:07 botanicus

@botanicus you can put a pull request on hold. You should either merge it or put the ticket on hold.

yegor256 avatar Jul 05 '18 16:07 yegor256

@yegor256 I tried, it’s broken. (I reported it.)

botanicus avatar Jul 06 '18 09:07 botanicus

@botanicus again, you can't put a pull request on hold. You tried to do exactly that.

yegor256 avatar Jul 06 '18 11:07 yegor256

@yegor256 you’re right, thanks!

botanicus avatar Jul 06 '18 15:07 botanicus

@botanicus this looks like a good PR. Can you please re-base it with master and we will merge.

yegor256 avatar Dec 10 '18 14:12 yegor256