zold icon indicating copy to clipboard operation
zold copied to clipboard

Commands’ help is not indented properly (hence unreadable)

Open botanicus opened this issue 6 years ago • 11 comments

Every single command has improperly aligned help banner: https://github.com/zold-io/zold/blob/master/lib/zold/commands/pay.rb#L43-L49

It doesn’t make sense and it’s hard to read. (And it’s not just my opinion.)

I inquired about what’s the minimal Ruby version we support. Assuming it’s 2.3 which has the squiggly heredoc, we can just do:

o.banner = <<~BANNER
  Usage: zold pay wallet target amount [details] [options]
  Where:
    'wallet' is the sender's wallet ID
    'target' is the beneficiary (either wallet ID or invoice number)'
    'amount' is the amount to pay, in ZLD, for example '14.95'
    'details' is the optional text to attach to the payment
  Available options:
BANNER

This will remove the whitespace used for indentation. In my opinion this is much more readable alternative.

botanicus avatar Jul 01 '18 23:07 botanicus

@yegor256/z please, pay attention to this issue

0crat avatar Jul 01 '18 23:07 0crat

@botanicus totally agree, thanks for the suggestion

yegor256 avatar Jul 02 '18 06:07 yegor256

Job #320 is now in scope, role is DEV

0crat avatar Jul 02 '18 06:07 0crat

Bug was reported, see §29: +15 point(s) just awarded to @botanicus/z

0crat avatar Jul 02 '18 06:07 0crat

@yegor256 may I have this ticket please?

botanicus avatar Jul 03 '18 05:07 botanicus

@0crat assign @botanicus

yegor256 avatar Jul 03 '18 08:07 yegor256

@0crat assign @botanicus (here)

@yegor256 The job #320 assigned to @botanicus/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

0crat avatar Jul 03 '18 09:07 0crat

It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @yegor256/z

0crat avatar Jul 03 '18 09:07 0crat

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

0crat avatar Jul 03 '18 09:07 0crat

@0crat wait

botanicus avatar Jul 06 '18 14:07 botanicus

@0crat wait (here)

@botanicus The impediment for #320 was registered successfully by @botanicus/z

0crat avatar Jul 06 '18 14:07 0crat