#42 Removed Mockito from NetworkTest

[carlosmiranda]

#42: Removed Mockito from NetworkTest. Added implementations of push() and pull() in Remote.Fake that can be used for testing purposes.

[0crat]

Job #64 is now in scope, role is REV

[codecov-io]

Codecov Report

Merging #64 into master will decrease coverage by 0.26%. The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
- Coverage     93.03%   92.77%   -0.27%     
  Complexity       49       49              
============================================
  Files            11       11              
  Lines           158      166       +8     
  Branches         10       11       +1     
============================================
+ Hits            147      154       +7     
  Misses           11       11              
- Partials          0        1       +1

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/io/zold/api/Remote.java	81.25% <72.72%> (+6.25%)	0 <0> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50f250c...74bf1ed. Read the comment docs.

[carlosmiranda]

@victornoel please check new commit addressing your comments. Also added TaxesTest, which I missed due to the fact that it seems to be a recent change.

[victornoel]

@carlosmiranda personally I like it better like that yes, also not that I am not the reviewer :)

[carlosmiranda]

@victornoel doh. This is not even assigned yet, you are working for free. :P

[victornoel]

@carlosmiranda just defending my interests by ensuring my future usage of those classes is a joy :D

[carlosmiranda]

@victornoel nevertheless it should be avoided, you are basically robbing both yourself and eventual assignee of the job (unless it turns out to be you). It's up to the architect to maintain joyful class usage.

[victornoel]

@carlosmiranda it's true, thanks for the reminder

[carlosmiranda]

@llorllale are there no reviewers available? This has become a long running task

[carlosmiranda]

@llorllale this is more than a week old now. Can you assign a REV or do the honor yourself?

[llorllale]

@carlosmiranda it's a funding issue - let me try to resolve it as quickly as possible