Tim-Niclas Oelschläger
Tim-Niclas Oelschläger
After a few more hours I have more questions - why are the ids in int64 and not uint64? - how should the permission be handled, because currently everybody who...
> Two things I noticed while testing:  > > 1. We should swap the order of `blocks`/`depends on` around, as the `depends on` is much more important in most...
> This is my subjective opinion as someone who made the feature request, items in priority order (this PR might already do some of them in that case ignore those...
> UI looks good. Only thing that maybe could be improved is to manually emit the separators in HTML instead of CSS because I fear that the CSS selector may...
The settings are used in `services/doctor/fix16961.go` did this file need a change?
> It's better to have a test for this since it has obvious un-tested parts. I think you mean the new functions `BlockingDependenciesMap` and `BlockedByDependenciesMap` The problem is, that I...
> > > It's better to have a test for this since it has obvious un-tested parts. > > > > > > I think you mean the new functions...
@lunny @6543 I hope this test is ok
> yes the your commit itselfe looks fine, the implications (as we use the fixtures for all tests ...) well have to be addressed. > > I'll have a look...
> Needs a merge in the migration files, then I will test it. I will wait for the last review from lunny, then I will resolve conflicts