Tim-Niclas Oelschläger

Results 24 comments of Tim-Niclas Oelschläger

After a few more hours I have more questions - why are the ids in int64 and not uint64? - how should the permission be handled, because currently everybody who...

> Two things I noticed while testing: ![grafik](https://private-user-images.githubusercontent.com/51889757/303793206-e9a05903-07de-4e0b-88fb-1e6560f6b128.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc1MjIxNzQsIm5iZiI6MTcwNzUyMTg3NCwicGF0aCI6Ii81MTg4OTc1Ny8zMDM3OTMyMDYtZTlhMDU5MDMtMDdkZS00ZTBiLTg4ZmItMWU2NTYwZjZiMTI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjA5VDIzMzc1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE3ZTkwMmMxNWU5NmY4ODc0Y2U2OTBlODY0YjFiN2YyMTMwN2M0NmQ3NzI0ZWIwYjE0NjAxZGFmYjVhOWFmNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DhJ27VYxy37pJt2zLi3o2-A2NphJ8N_lpYzdGTUV_VY) > > 1. We should swap the order of `blocks`/`depends on` around, as the `depends on` is much more important in most...

> This is my subjective opinion as someone who made the feature request, items in priority order (this PR might already do some of them in that case ignore those...

> UI looks good. Only thing that maybe could be improved is to manually emit the separators in HTML instead of CSS because I fear that the CSS selector may...

The settings are used in `services/doctor/fix16961.go` did this file need a change?

> It's better to have a test for this since it has obvious un-tested parts. I think you mean the new functions `BlockingDependenciesMap` and `BlockedByDependenciesMap` The problem is, that I...

> > > It's better to have a test for this since it has obvious un-tested parts. > > > > > > I think you mean the new functions...

@lunny @6543 I hope this test is ok

> yes the your commit itselfe looks fine, the implications (as we use the fixtures for all tests ...) well have to be addressed. > > I'll have a look...

> Needs a merge in the migration files, then I will test it. I will wait for the last review from lunny, then I will resolve conflicts