Raspberry-Pi-E-Ink-Dashboard icon indicating copy to clipboard operation
Raspberry-Pi-E-Ink-Dashboard copied to clipboard

Moved user values to .env & added .gitignore

Open saarmstrong opened this issue 4 years ago • 1 comments

Hey man, hope this is not too presumptuous but I wanted to ask how you would feel about some small QoL suggestions:

  • Move the user specific values to a .env file that would allow the user to store their personal values without the fear of checking them in and publishing to github
  • Added a .gitignore file to prevent myself (and others) from accidentally checking in their .env and generated pycache files

I am (impatiently) waiting on my e-ink screen to arrive, but I have tested this locally and I see the expected console logs as I saw when I ran the command on your main branch.

saarmstrong avatar Oct 05 '20 03:10 saarmstrong

Not presumptuous at all, I'm glad to see someone improve upon my code. I reviewed your changes, and they look good. I'll clone the repo with your changes to my rpi and make sure everything works and then approve it. Thanks for your contribution!

zoharsf avatar Oct 06 '20 16:10 zoharsf