sails-rest
sails-rest copied to clipboard
zohararad
Upgrade restify to >=3.0.0
Currently, sails-rest installs [email protected]. And with node 0.12 or iojs, I get these errors:
{ [Error: Cannot find module './build/Release/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
{ [Error: Cannot find module './build/default/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
{ [Error: Cannot find module './build/Debug/DTraceProviderBindings'] code: 'MODULE_NOT_FOUND' }
From what I've been able to figure out, this is fixed by using dtrace-provider >=0.4.0, which [email protected] satisfies.
Were you able to run sails-rest with restify 3.0.0 ? I'm happy to accept a PR that resolves this
@joshuajabbour please take a look at v0.1.0-waterline-v0.10 . It's a complete re-write of the adapter (doesn't use restify anymore). I plan to let it sit in that branch for a while before releasing, but it might be a good way to work around the problem you described above.
@zohararad its great to see oncoming official superagent version! I made dirty port before to use in isomorphic fluxible application. Let me know if I can help somehow.
@ertrzyiks glad for the positive comments. I'd love to get some feedback on
- Code quality if you're happy looking through it
- Usefulness in a real application. Most bugs come from real-world usage and I may have missed some things