Sebastian Zoglowek
Sebastian Zoglowek
> You will always see that something is cut off and then try to scroll imho You said it yourself `that browsers can be any width`. In specific cases, you...
See: https://github.com/contao/package-list/pull/14
> That‘s just one more reason to enhance tl_files. A listener could add input fields for tl_files.subtitlesLanguage and tl_files.subtitlesType if the filetype is VTT. That one was missing :( >...
> This is all we need IMHO We'd still need to check if label (title) or language are set because they'd be invalid without. There is currently 4 subtitle kinds...
> We can show a warning in the player element if one of the subtitles files has incomplete metadata. I agree > Does this mean that the `kind` attribute is...
> > As discussed prior with @leofeyer , we do need kinds of subtitles since there is 4 mentioned ones in the moz docs but actually even 5 existing ones:...
Expected PHP 8.1 check is unrelated and most likely due to raising min PHP-Version to PHP 8.2
This is ready for another review (and hopefully ready to merge) There is one last conversation that could be ignored or not / could be implemented in a follow-up PR....
> I always wonder why we have a checkbox that enables a mandatory selector field, instead of just having a non-mandatory file picker? It seems kind of common in Contao,...
@aschempp see bb0209589b324ec5b57b10a7fa427cc8e49bde50 Since it's null (even after saving), this works. Does not need to be mandatory at all, the rest is being handled within the listener and PlayerController (There...