Zoe Faltibà
Zoe Faltibà
> With https://github.com/BP-WG/bp-wallet/pull/49 the test now passes and RBFs work. I confirm test now passes, PR ACKed > My changes for integration tests can be found in https://github.com/zoedberg/rgb-integration-tests/pull/1/files This contains...
@dr-orlovsky can we move this to a later milestone? 0.12 for example should be ok
> Why not both? It is good for the users to be able to check invoices with just eyes, not knowing the maximum precision of an asset. IMO because adding...
> There is no floating point: a precision makes two integers instead of floating point. You should handle the case in which you set both the integers to the max...
> You have to handle overflows anyway, independently from the way you present amounts Just 1 overflow instead of 3 (1 for merged number, 1 for left part and 1...
> there is no reason to manually parse invoice. If you think there are no reasons to manually parse the invoice then I don't understand why do you think we...
I'm happy you changed your mind on this and I think the proposed approach is better than the current one
@dr-orlovsky this isn't listed in the rgb 0.11 board (https://github.com/orgs/RGB-WG/projects/17), do you still plan to do it in a 0.11 release or should we move the task to a 0.12...
> This is not a guarantee - PaymentSent indicates that we received the preimage back for our payment (i.e. might happen before we even see a new commitment transaction) and...
> How is this different from #271? In https://github.com/RGB-WG/rgb-std/issues/271 the receiver was failing to validate the consignment with the following error: ``` thread 'tapret_wlt_receiving_opret' panicked at tests/utils/helpers.rs:779:85: called `Result::unwrap()` on...