TotalRegistry icon indicating copy to clipboard operation
TotalRegistry copied to clipboard

Expanding keys with lots of subkeys takes a long time and/or hardlocks

Open God-damnit-all opened this issue 2 years ago • 21 comments

If I attempt to expand HKEY_CLASSES_ROOT (clicking the area in red): image ... TotalReg completely freezes. I let it try to do its thing for about 5 minutes before I gave up.

I instead went and expanded HKEY_CURRENT_USER\SOFTWARE\Classes and that did work, but it took a little over a minute.

In regedit, it takes only about a second to do either of these things.

If there's something you need me to do to help debug this, I'd be happy to help. I do have Visual Studio 2022 and could (probably) compile this to use its debugging features, but I'm a novice and you'd need to tell me what steps to take, what lines of code to set a breakpoint at, etc.

Also, even if this is fixed in TotalReg to also be a second or so, it'd be nice if the left pane could run on an asynchronous thread that doesn't lock up the rest of the program while it's expanding a key with lots of subkeys.

God-damnit-all avatar Jul 16 '23 21:07 God-damnit-all

Yes, it seems it finishes, but it takes too long. I will investigate.

zodiacon avatar Jul 16 '23 22:07 zodiacon

Probably fixed bug. See latest commit. Thanks!

zodiacon avatar Jul 16 '23 22:07 zodiacon

Probably fixed bug. See latest commit. Thanks!

Should I compile it or will you be releasing a new version?

God-damnit-all avatar Jul 16 '23 23:07 God-damnit-all

I've put the binary for now in the AllTools repo. I will create a new release once I'm sure enough it's good.

zodiacon avatar Jul 16 '23 23:07 zodiacon

Thank you. Yep, seems to be working!

It's still not as quite as fast as regedit's expansion (it takes a few seconds for HKEY_CLASSES_ROOT), but it's certainly useable now.

God-damnit-all avatar Jul 16 '23 23:07 God-damnit-all

Yes, I have an idea on how to improve the speed...

zodiacon avatar Jul 17 '23 00:07 zodiacon

@zodiacon I've been using TotalReg with the change for a bit now, I think it's safe to make a release with it.

God-damnit-all avatar Jul 29 '23 19:07 God-damnit-all

Thanks! Appreciate the testing.

zodiacon avatar Jul 29 '23 19:07 zodiacon

@zodiacon Ah hell, figures just hours after I posted that I came across something.

Apparently it still hangs for a really long time when you refresh with F5.

God-damnit-all avatar Jul 30 '23 00:07 God-damnit-all

I'll look into it.

zodiacon avatar Jul 30 '23 00:07 zodiacon

I'll look into it.

My sincerest apologies for not catching it before, I wasn't really in a position where I needed to actually continuously check back on changes I'd made, but I was messing around with stuff yesterday related to context menu launchers that's when I noticed it.

Anyway, I downloaded the new build off the AllTools repo, and, with TotalReg's path set to the HKEY_CLASSES_ROOT\LibraryFolder\background\shell Key, when I press F5, it's still exhibiting the same behavior as before, effectively just locking up until the end of time.

God-damnit-all avatar Jul 30 '23 18:07 God-damnit-all

No need to apologize :) I believe I fixed it, grab the binary from the AllTools repo.

zodiacon avatar Jul 30 '23 18:07 zodiacon

No need to apologize :) I believe I fixed it, grab the binary from the AllTools repo.

I'm afraid that's the binary I was referring to, I grabbed it just minutes before I replied just now.

God-damnit-all avatar Jul 30 '23 18:07 God-damnit-all

What is the full URL to the AllTools repository?

Charles S Galloway

On Sun, Jul 30, 2023 at 2:29 PM Pavel Yosifovich @.***> wrote:

No need to apologize :) I believe I fixed it, grab the binary from the AllTools repo.

— Reply to this email directly, view it on GitHub https://github.com/zodiacon/TotalRegistry/issues/57#issuecomment-1657237071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAX6VRMPVVDJUNER3CBWFDXS2RWXANCNFSM6AAAAAA2MFZSII . You are receiving this because you are subscribed to this thread.Message ID: @.***>

CSGalloway avatar Jul 30 '23 21:07 CSGalloway

https://github.com/zodiacon/AllTools

zodiacon avatar Jul 30 '23 21:07 zodiacon

I'm experiencing the same behavior as @ImportTaste (using official release binary and AllTools repo binary as well) - pressing F5 on HKEY_CLASSES_ROOT locks up TotalRegistry.

piterq avatar Nov 01 '23 14:11 piterq

Thanks for the report, I will investigate.

zodiacon avatar Nov 01 '23 14:11 zodiacon

I meet same question when I expand the "HKEY_CLASSES_ROOT", Version=v0.9.7.5

iamqiz avatar Jan 10 '24 23:01 iamqiz

Please try version 0.9.7.6 from the AllTools repo

zodiacon avatar Jan 10 '24 23:01 zodiacon

@zodiacon https://github.com/zodiacon/AllTools/releases/tag/v0.9.7.5 ? it work (taking less time to expand HKCR), thanks!

iamqiz avatar Jan 10 '24 23:01 iamqiz

The Refresh lag is fixed, though I ended up noticing another bug in the process:

https://github.com/zodiacon/TotalRegistry/issues/63

___

God-damnit-all avatar Jan 11 '24 02:01 God-damnit-all