minify-js-sourcemaps icon indicating copy to clipboard operation
minify-js-sourcemaps copied to clipboard

3.4% bundle size increase after upgrading from 4.x to 5.1.2

Open alisnic opened this issue 2 years ago • 2 comments

Not sure whether it's really an issue, but it would be interesting whether anyone has any insights as to why this might happen.

Screenshot 2023-07-27 at 09 51 51

alisnic avatar Jul 27 '23 06:07 alisnic

Now since #35 got fixed, I see the same issue in our app:

874M  build-new/bundle/programs
839M  build-old/bundle/programs

772M  build-new/bundle/programs/server
772M  build-old/bundle/programs/server

52M build-new/bundle/programs/web.browser
34M build-old/bundle/programs/web.browser

51M build-new/bundle/programs/web.browser.legacy
34M build-old/bundle/programs/web.browser.legacy

8.6M  build-new/bundle/programs/web.browser/4d5ffa015be53bdfae31104534de5bf37056062c.js.map

18M   build-new/bundle/programs/web.browser/dynamic
8.9M  build-old/bundle/programs/web.browser/dynamic

16M   build-new/bundle/programs/web.browser/app
16M   build-old/bundle/programs/web.browser/app

1.3M  build-new/bundle/programs/web.browser/program.json
788K  build-old/bundle/programs/web.browser/program.json

6.9M  build-new/bundle/programs/web.browser/4d5ffa015be53bdfae31104534de5bf37056062c.js
6.8M  build-old/bundle/programs/web.browser/7ffcc57cd00d054b1633f314dc879fa01a6082aa.js

220K  build-new/bundle/programs/web.browser/4d5ffa015be53bdfae31104534de5bf37056062c.stats.json
220K  build-old/bundle/programs/web.browser/7ffcc57cd00d054b1633f314dc879fa01a6082aa.stats.json

124K  build-new/bundle/programs/web.browser/packages
124K  build-old/bundle/programs/web.browser/packages

4.0K  build-new/bundle/programs/web.browser/head.html
4.0K  build-old/bundle/programs/web.browser/head.html

1.2M  build-new/bundle/programs/web.browser/866e7cc6595bd4477ec8f4124fe3a51c87d050e9.css
1.2M  build-old/bundle/programs/web.browser/866e7cc6595bd4477ec8f4124fe3a51c87d050e9.css

However, after I got rid of all .map files, the difference is ~2.1% increase in the main bundle size (~0.1% increase gzipped). I guess that's just the matter of different minifier, e.g., different handling of long template strings or even mangling ordering (the bundle looks completely different).

radekmie avatar Jul 27 '23 07:07 radekmie

That's interesting. Currently it uses the same settings for both the legacy and modern clients. We probably could adjust how it minifies the modern client to enable more optimizations.

zodern avatar Jul 27 '23 16:07 zodern