react-native-push-notification icon indicating copy to clipboard operation
react-native-push-notification copied to clipboard

Fixed repeatType for day

Open ktarasenkowow opened this issue 2 years ago • 5 comments

Dont work date option if set repeatType="day"

ktarasenkowow avatar Mar 11 '22 09:03 ktarasenkowow

I think the right solution is this: https://github.com/zo0r/react-native-push-notification/pull/2229, maybe could merge this? It's a minimal change @Dallas62

BrandonMA avatar Apr 01 '22 09:04 BrandonMA

@BrandonMA It is fixed dev build but broke release build... If u want test daily notification - change node_modules but stay original for release=) I dont now why repeatType === 'month' correct work for release-_-

ktarasenkowow avatar Apr 01 '22 09:04 ktarasenkowow

Mmm weird, we have been using this fix at my company and it works. If you check the iOS documentation if you want the notification to repeat every day then you need second, minute, and hour. If you pass day it will repeat the notification every month, let's say I create a notification for April 1st and pass day, then the next notification I will receive is for May 1st.

In any case, you can also fork the project and consume the library directly from Github, that's what we did.

BrandonMA avatar Apr 01 '22 09:04 BrandonMA

As mentioned in the linked PR: https://github.com/zo0r/react-native-push-notification#state-of-the-repository

I highly recommend to move from this library to an other which is actively maintained. I don't have time anymore, and I don't use the library anymore.

Regards.

Dallas62 avatar Apr 01 '22 09:04 Dallas62

Maybe @Narmical will be able to help you soon.

Dallas62 avatar Apr 01 '22 09:04 Dallas62

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 09 '23 00:05 github-actions[bot]