pytorch-generative-model-collections icon indicating copy to clipboard operation
pytorch-generative-model-collections copied to clipboard

Published 20 hours ago • verified publisher icon znxlwm

Missed a colon in InfoGAN code

Open back2yes opened this issue 6 years ago • 1 comments

Great job. By the way, I found this line of code doubtful:

https://github.com/znxlwm/pytorch-generative-model-collections/blob/5207b2fda3a9832c182e27dbbf2658b3078021ef/infoGAN.py#L78

Maybe this line should be changed into: a = F.sigmoid(x[:, : self.output_dim])

back2yes avatar Mar 03 '18 09:03 back2yes

Agreed - just spotted your issue after making this fix in a pull request.

jmmcd avatar May 23 '18 15:05 jmmcd