Florian Zenker

Results 26 comments of Florian Zenker

I think this is https://github.com/anchore/grype/issues/558

Please provide more details and ideally a small program to reproduce the error you are seeing.

This issue should be handled at the build system level, for example by verifying the the correct protoc version is installed.

[protocmp](https://pkg.go.dev/google.golang.org/protobuf/testing/protocmp) is the recommended library to use for proto comparisons. I don't think the same matching functionality exists there though. Maybe create a feature request for that library?

Oups. I guess I should have known that :)

Mhmm, that sounds like it's not too much work indeed. I think the main difference would be that would have to work asymmetrically (at least that's how I understand how...

Just checked: [cmp.FilterValues](https://pkg.go.dev/github.com/google/go-cmp/cmp#FilterValues), which I think is used underneath, documents that the provided filter function has to be symmetric.

Thanks for checking! We're not sure if and when we get to this, but we're definitely happy to review contributions. :)

IIUC, the issues was in the protoc compiler: https://github.com/protocolbuffers/protobuf/issues/9483#issuecomment-1040393475. Since that compiler is not part of the Go module, the module itself is not affected. However, it's still possible to...

We discussed this internally and more or less aligned on ```go // CloneOf returns a deep copy of m. If the top-level message is invalid, // it returns an invalid...