rust-ffmpeg icon indicating copy to clipboard operation
rust-ffmpeg copied to clipboard

remove filter::Context generic lifetime parameter

Open VincentJousse opened this issue 1 year ago • 2 comments

issue #193

VincentJousse avatar Jul 03 '24 10:07 VincentJousse

hi! Thanks for your submission :) I just fixed the linting, errors, could you rebase on master to check if the CI's green?

Polochon-street avatar Jul 16 '24 15:07 Polochon-street

Done ;)

VincentJousse avatar Jul 19 '24 08:07 VincentJousse

Would you rebase again? There were new clippy errors, seems that rust updates faster than I can fix lints...

Polochon-street avatar Jul 27 '24 22:07 Polochon-street

@Polochon-street Done again !

VincentJousse avatar Jul 30 '24 08:07 VincentJousse

thanks!

Polochon-street avatar Jul 30 '24 14:07 Polochon-street

@Polochon-street just a reminder : this MR breaks the API !! Do you plan any release soon ?

VincentJousse avatar Jul 31 '24 07:07 VincentJousse

Unfortunately, that crate doesn't follow semver, so I can only release minor versions (otherwise the build script will try and fetch e.g. ffmpegv7.1 as far as I remember). I'll release a new version now :)

Polochon-street avatar Jul 31 '24 16:07 Polochon-street

it should be released now.

Polochon-street avatar Jul 31 '24 17:07 Polochon-street