zmstone

Hi @slashmili It'd have to be configurable though. WDYT? @ieQu1 @qzhuyan @id and @kjellwinblad @starbelly @vikas15bhardwaj inputs are appreciated.

Hi @slashmili Ideally the dependency should be optional for users who do not need beam-telemetry. We can probably introduce a `brod_telemetry` module to confine the telemetry dependencies and use a...

I’m thinking about it more from dependency hygiene perspective but not concerned about performance. Given it’s essentially two apis to integrate, I assumed it’s not a big effort to implement....

fair enough, Make sense to have the instrumentation code defined as `BROD_` prefixed macros? So a wrapping project still has the chance to change to other calls without going though...

Thanks you all for the ideas. I have pushed a branch `dev/telemetry`, let's start instrumenting the code in this branch, when everybody is happy with the instrumentations, we can merge...

Hi again @tsloughter I am not quite sure what would `opentelemetry_brod` do, or why you brought it up, is there any reason why someone should **not** include `opentelemetry_api` but create...

Hi @SerikDM Sorry for the late reply. Could you remind me why `{:ok, -1}` will not work? Is it because `-1` is translated to `latest` ? We can maybe support...

or `{:ok, {:start_from_offset, N}}`

the issue is here: https://github.com/kafka4beam/brod/blob/b3eb0fee8ecac7d47d13c90ef7ae798a8f9870a1/src/brod_group_subscriber_worker.erl#L79

Hi @SerikDM `0` is what I missed in my fix, should have translated it to `earliest`. Now it's actually implicitly translated into `latest`.