zmk icon indicating copy to clipboard operation
zmk copied to clipboard

feat(split): Compile additional events on peripheral

Open ReFil opened this issue 1 year ago • 3 comments

In preparation for the re-do of #2036 events that are useful for displays/indicators on the peripheral should be compiled on both sides so they can be raised on both sides

PR check-list

  • [x] Branch has a clean commit history
  • [x] Additional tests are included, if changing behaviors/core code that is testable.
  • [x] Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • [x] Pre-commit used to check formatting of files, commit messages, etc.
  • [x] Includes any necessary documentation changes.

ReFil avatar Jan 02 '25 11:01 ReFil

This PR has been automatically marked as stale because it has not had activity in 10 months. It will be closed in 14 days if no further activity occurs. Feel free to give a status update or re-open when it has been rebased and is ready for review (again). Thanks!

github-actions[bot] avatar Nov 07 '25 14:11 github-actions[bot]

This pr is ready for review

ReFil avatar Nov 10 '25 10:11 ReFil

I agree with the changes made here. I wonder if we could take this opportunity to think about some convention about which events get compiled on all split parts Vs which get compiled only on the central?

Personally I think we may as well compile all events on all split parts, unless there is a strong argument otherwise (saving memory on the peripheral is not a convincing argument considering the tiny savings imo).

nmunnich avatar Nov 10 '25 13:11 nmunnich