zmk icon indicating copy to clipboard operation
zmk copied to clipboard

fix(devcontainer): Add packages required by grpcio

Open c10l opened this issue 11 months ago • 4 comments

When running pip3 install --user -r zephyr/scripts/requirements.txt (last step on https://zmk.dev/docs/development/setup), grpcio install fails with the following error:

FileNotFoundError: [Errno 2] No such file or directory: c++: c++

This happens due to missing dev tooling in the container.

c10l avatar Mar 22 '24 00:03 c10l

Should this rather go into the dev-generic part of https://github.com/zmkfirmware/zmk-docker to include the dev tooling into the dev base image directly rather than just adding it to the devcontainer here?

huber-th avatar Mar 22 '24 03:03 huber-th

I'm not sure but I opened one there and referenced this one.

c10l avatar Mar 23 '24 11:03 c10l

I'm... a little hesitant to do this; the reality is, this is coming in from requirements-extras.txt in Zephyr, which has a lot of stuff that is not required for normal users to just build for their keyboards.

We used to only document installing the requirements-base.txt deps from Zephyr, but it looks like that got changed in 82ff6d8e857bf581714f2a2e23af3aa6bf4cf4e2 by Joel. @joelspadin is there a specific reason we changed that I don't recall, or could we go back to just recommending the base deps?

petejohanson avatar Apr 11 '24 07:04 petejohanson

I don't remember. I probably just copied it from the Zephyr docs somewhere?

joelspadin avatar Apr 12 '24 04:04 joelspadin