zmk icon indicating copy to clipboard operation
zmk copied to clipboard

feature(shields): Add nice!view

Open Nicell opened this issue 2 years ago • 2 comments

Board/Shield Check-list

  • [x] This board/shield is tested working on real hardware
  • [x] Definitions follow the general style of other shields/boards upstream (Reference)
  • [x] .zmk.yml metadata file added
  • [x] Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • [x] General consistent formatting of DeviceTree files
  • [ ] Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • [x] &pro_micro used in favor of &pro_micro_d/a if applicable
  • [ ] If split, no name added for the right/peripheral half
  • [x] Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • [ ] .conf file has optional extra features commented out
  • [x] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Nicell avatar Sep 21 '22 20:09 Nicell

Is this definition intended to be used along with other shields using a build definition with multiple shields? If so, does the Github actions workflow support such a definition through build.yaml?

Is this also supposed to be compatible with nice!nano only (or with pro micro boards, for that matter)? I don't see why that should be, but it seems like the case from the SPI node alias.

caksoylar avatar Sep 22 '22 04:09 caksoylar

Is this definition intended to be used along with other shields using a build definition with multiple shields? If so, does the Github actions workflow support such a definition through build.yaml?

Exactly! The GitHub actions workflow should work fine according to Pete... I need to test it though. Should just need to update the build.yaml shield prop to have nice_view after the existing one, so user configs should be fine. The repository's build workflow does need to be updated though.

Is this also supposed to be compatible with nice!nano only (or with pro micro boards, for that matter)? I don't see why that should be, but it seems like the case from the SPI node alias.

Should be compatible with all the other Pro Micro boards, I just need to define SPI nodes/aliases for others, which is on my todo.

Nicell avatar Sep 22 '22 04:09 Nicell

Our requires/exposes system doesn't really handle this new type of interconnect (built on top of a complete keyboard, not to create one). We'll need to figure out how we handle this with our build system and our hardware docs page. I've set up stubs and done nothing with them for now for both the build system and docs.

Nicell avatar Sep 26 '22 01:09 Nicell