redux-form-antd icon indicating copy to clipboard operation
redux-form-antd copied to clipboard

Update to Ant 3.16.2

Open davidpanzarella opened this issue 5 years ago • 7 comments

Any chance you can pull in the latest Ant version?

davidpanzarella avatar Apr 05 '19 22:04 davidpanzarella

Hi @davidpanzarella, we've tried it and it introduced some breaking style changes that required further modifications in our component styling, so we decided not to do that for the time being. Have you tested this version without any issues?

mrlubos avatar May 05 '19 11:05 mrlubos

I haven't tested it, but we're on the latest Ant build in our app, and notice issues with this library. Doesn't seem to be very active, so we'll likely forgo using it.

davidpanzarella avatar May 06 '19 03:05 davidpanzarella

@davidpanzarella Can you please describe what issues you're seeing? Thanks!

mrlubos avatar May 06 '19 22:05 mrlubos

Hi @mrlubos, we're mainly seeing issues with consistency. Some styles are not getting pulled in when including components from this library, which are likely due to the version of ant used in this version of redux-form-antd.

davidpanzarella avatar May 21 '19 04:05 davidpanzarella

But library has only peer dependency of antd, what its the problem?

zmitry avatar May 27 '19 19:05 zmitry

The first issue is that not all the styles get imported. Take an example like this:

        <Field
            name="ShortDescription"
            component={TextAreaField}
            label="Short Description"
            placeholder="My Awesome Project"
            validate={
              [
                required({ message: 'Short description is required' }),
                length({ min: 20, message: 'Short description must be at least 20 characters' }),
                length({ max: 200, message: 'Short description must be less than 200 characters' })
              ]
            }
          />

Doing the above should work by just doing this import { TextAreaField } from 'redux-form-antd';

However, no styles will get included unless I also import Input from antd, and also pull out TextArea from Input. Eg. const { TextArea } = Input; // required to get styles to work with antdreduxform

Other issues I've seen also have to do with getting the number counter to work in an InputNumber, as well as, the styling Ant feedback for things like error messages and other error feedback. Like so:

Screen Shot 2019-05-27 at 12 44 12 PM

davidpanzarella avatar May 27 '19 19:05 davidpanzarella

Would it be enough to import the style?

import 'antd/lib/input/style';

kilya11 avatar Aug 19 '19 13:08 kilya11