Zach Loafman
Zach Loafman
Looks great! Sent #3827 to fix a minor issue.
Hmm, interesting idea, but.. > No PortPolicy and no ports configured. This is legit what I would expect to configure in this case, since you're not asking us to manage...
I am primarly pushing back because OSS projects tend to just keep accepting complexity until it eventually becomes a too complicated system. I'm wondering if we can come up with...
I think I also like the idea of `None`, with the structure of #3807, and would prefer it to exposing it in the template, which feels a little funny. Let's...
> ## Apply Default > I like the approach. But you would want to `ApplyDefaults()` here: You're right. It might be nice if we had a helper function here that's...
> Are we requiring that all changes (for Feature Gate, SDK Server, SDK Client, Config) must go from Alpha -> Beta -> Stable? Or are we allowing for changes to...
> LGTM - just a couple of extra thoughts: > > ### UI/UX > > The system must function normally during an upgrade, from a user's perspective > > Adding...
@towolf What's your session length? And this is GKE if I remember, right? Adding `safe-to-evict=false` on allocation is infeasible due to the race that @roberthbailey mentioned - the best we...
Tracking this in an internal bug, will report back.
I would tend towards to a denylist but make it less broad. In particular, things like `.sh`, `.toml`, `.asset`, `.csproj` are all part of the build, so maybe ignore: *.md,...