lua-resty-openidc icon indicating copy to clipboard operation
lua-resty-openidc copied to clipboard

Revert the deprecation of the redirect_uri_path option

Open voronin-ilya opened this issue 2 years ago • 0 comments

Environment
  • lua-resty-openidc version 1.7.6
  • JupyterHub OAuth Provider (https://jupyterhub.readthedocs.io/en/stable/explanation/oauth.html)
Expected behaviour

The OAuth provider I am using mandates that the redirect_uri be a relative path (/user/${user}/oauth_callback), and this setting cannot be altered on the provider's end. I anticipated the ability to configure lua-resty-openidc accordingly.

Actual behaviour

I had to modify the code because currently, the redirect_uri (and redirect_uri_path) is invariably transformed into an absolute URL.

https://github.com/voronin-ilya/lua-resty-openidc/commit/381c7ce1896bdcc8972debcab9fa66bf1907af16

Proposal

To ensure compatibility with the JupyterHub OAuth provider, I propose rolling back the deprecation of the redirect_uri_path option.

voronin-ilya avatar Nov 15 '23 10:11 voronin-ilya