zlint icon indicating copy to clipboard operation
zlint copied to clipboard
verified publisher icon zmap

Add close-primes detection via Fermat's factorization

Open vanbroup opened this issue 3 years ago • 3 comments

zlint is currently missing a close-primes lint, maybe we can repurpose the check from boulder for this?

https://github.com/letsencrypt/boulder/commit/89000bd61cfc6f373cb48b6f046d4fce7df5468e

https://fermatattack.secvuln.info/

cc: @aarongable

vanbroup avatar Apr 26 '22 12:04 vanbroup

Happy for the boulder implementation to be reused for this, but I don't currently have time to put together the zlint PR myself, sorry!

aarongable avatar Apr 27 '22 16:04 aarongable

No problem, thanks for letting this code be used. I can work on this in a few weeks (currently on vacation).

vanbroup avatar Apr 27 '22 18:04 vanbroup

@aarongable @vanbroup the change listed in Boulder is reasonably contained (and commented) so I can take a crack at this. Although, I may enlist Aaron (or at least @ mention them) in the PR for a smoke check

christopher-henderson avatar May 08 '22 13:05 christopher-henderson

Should this bug be considered fixed/closed, or is there more work to do now that #674 has been merged?

aarongable avatar Aug 31 '22 18:08 aarongable