zgrab2 icon indicating copy to clipboard operation
zgrab2 copied to clipboard

Bump go version and update dependencies

Open phillip-stephens opened this issue 1 year ago • 1 comments

  • Updated go version in go.mod
  • Ran go get -u to update all dependencies
  • Ran go mod tidy to get rid of unneeded dependencies
  • Updated tests to use new go version for build checks

How to Test

Add brief instructions on how to test your changes.

Notes & Caveats

If necessary, explain the motivation for this PR, and note any caveats that apply to your changes or future work that will be needed.

Issue Tracking

Add a link to the relevant GitHub issue(s) if the pull request resolves it.

phillip-stephens avatar Jun 05 '24 21:06 phillip-stephens

(trying to be helpful)

This error seems relevant- could be an issue with the schema validation code itself rather than the zgrab2 output being validated

specifically, the first ERROR line, which seems to be a dict that didn’t get correctly deserialized

ERROR:root:data.postgres.result.tls.handshake_log.server_hello.compression_method: class mismatch for compression_method: expected (<class 'future.types.newint.newint'>,), {u'hex': u'0x00', u'name': u'NULL', u'value': 0} has class dict
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/runner/.local/lib/python2.7/site-packages/zschema/__main__.py", line 112, in <module>
    main()
  File "/home/runner/.local/lib/python2.7/site-packages/zschema/__main__.py", line 106, in main
    args.validation_policy_override)
  File "/home/runner/.local/lib/python2.7/site-packages/zschema/compounds.py", line 503, in validate
    self._handle_validation_exception(calculated_policy, e)
  File "/home/runner/.local/lib/python2.7/site-packages/zschema/keys.py", line 208, in _handle_validation_exception
    raise e
zschema.keys.DataValidationException

mzpqnxow avatar Aug 23 '24 12:08 mzpqnxow

Closing since this was handled in this merged PR.

phillip-stephens avatar Jan 22 '25 23:01 phillip-stephens