fix http retry-https and use-https default port to 443

[fengdingbo]

fix http retry-https and use-https default port to 443

How to Test

Before：

echo oldpassport.ch.com|zgrab2 http --retry-https {"domain":"oldpassport.ch.com","data":{"http":{"status":"unknown-error","protocol":"http","result":{},"timestamp":"2022-03-29T16:07:26+08:00","error":"net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}}}

After repair:

echo oldpassport.ch.com|zgrab2 http --retry-https {"domain":"oldpassport.ch.com","data":{"http":{"status":"success","protocol":"http","result":{"response":{"status_line":"200 OK","status_code":200,"protocol":{"name":"HTTP/1.1","major":1,"minor":1},"headers":{"cache_control":["private"],"content_type":["text/html; charset=utf-8"],"date":["Tue, 29 Mar 2022 08:08:56 GMT"],"server":["Microsoft-IIS/10.0"],"vary":["Accept-Encoding"]},"body":"\u003c!DOCTYPE HTML\u003e\r\n\u003chtml\u003e\r\n\u003chead\u003e\r\n \u003cmeta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" /\u003e\r\n \u003cmeta http-equiv="Cache-Control" content="private,must-revalidate" /\u003e\r\n \u003cmeta http-equiv="Content-Type" content="text/html; charset=utf-8" /\u003e\r\n \u003cmeta property="qc:admins" content="51560247013307246306375" /\u003e ....,"length":48}}}}}}},"timestamp":"2022-03-29T16:09:04+08:00"}}}

[mzpqnxow]

Hey @fengdingbo, I'm not a zmap/zgrab2 developer (just a very, very minor/occasional contributor / heavy user) but I wanted to add a comment on your PR here as one of your changes would negatively impact my use of zgrab2

Specifically, the "before" behavior of retry-https that you describe- retrying with HTTPS protocol on the same port- is desired in my case. If the behavior was changed to attempt the request on a different port as you propose with this PR, I would ask that it be made an explicit/optional flag. This is for several reasons, the least of which is that in my use, open ports are pre-gathered before going to zgrab2 in a comprehensive targets CSV file format file, so the "after" behavior would cause multiple requests to port 443- which really adds up to both wasted bandwidth, run time and load on targets at scale

The other change- defaulting to 443 when use-https doesn't really impact me so no complaints there. It seems quite convenient, actually

Just my $.02

[developStorm]

Thanks for the PR @fengdingbo and thanks for sharing your thoughts @mzpqnxow.

Adding on top of @mzpqnxow's comment, as how ZGrab2 processes parameters now, it would be impossible for users to scan HTTPS on port 80 if we adopt this change. Therefore we are unfortunately not able to merge this. I'm going to close the PR for now, but feel free to comment for any follow-ups.