zgrab2 icon indicating copy to clipboard operation
zgrab2 copied to clipboard

Miscellaneous flags for HTTP module and HTTP POST body support (chunked and plain)

Open mzpqnxow opened this issue 2 years ago • 4 comments

As described in #338 (and the title of the PR)

Needs review, though it is currently working well enough for me. I'm not a golang guy

mzpqnxow avatar Dec 29 '21 21:12 mzpqnxow

@dadrian @zakird any interest in accepting this one, or any feedback on how it was implemented?

Looks like there are some merge conflicts since I sent it, I can fix them up if you have interest in merging

Thanks!

mzpqnxow avatar Feb 15 '22 12:02 mzpqnxow

@dadrian @zakird bump... thoughts? It's all optional, requiring explicit flags to the http module CLI, so I'm thinking this would have a small (ideally zero) impact on users. It's worked well for me to date

mzpqnxow avatar Apr 13 '22 14:04 mzpqnxow

This seems fine but please fix the merge and then @ me again

dadrian avatar Apr 15 '22 00:04 dadrian

Yeah, I'm a doofus and based this on TLS1.3, but submitted against master. D'oh!

I only use TLS1.3 so selfishly I would like to resubmit against TLS1.3 only, but I'll see if I can adapt it to master, it shouldn't be too bad, I guess

mzpqnxow avatar Jul 02 '22 12:07 mzpqnxow

Hey @dadrian @mzpqnxow – this would be really awesome to have!

lc avatar May 07 '23 01:05 lc

Hey @dadrian @mzpqnxow – this would be really awesome to have!

Been meaning to get back around to rebasing this

You wouldn't happen to write/work with golang code would you? My commits are all here, they just needs to be grafted onto the correct branch

I want to do it but haven't had the time, and I have a build of that branch handy whenever I need it, which has let me keep deferring this

mzpqnxow avatar May 13 '23 23:05 mzpqnxow

Hey @dadrian @mzpqnxow – this would be really awesome to have!

@lc any interest in taking this over from me? It works but needs to be rebased. I haven't had any time, unfortunately

mzpqnxow avatar Dec 05 '23 14:12 mzpqnxow

Oops, I see @lc already did it! Thanks!

mzpqnxow avatar Dec 05 '23 14:12 mzpqnxow