MSF-XINPUT icon indicating copy to clipboard operation
MSF-XINPUT copied to clipboard

Published 20 hours ago • verified publisher icon zlittell

Fix xinput security string

Open gdsports opened this issue 6 years ago • 1 comments

@dmadison @zlittell The security string should be specified as ASCII characters, not 16 bit unicode. The extra 0x00 are added later when the string descriptor is sent. With this patch, lsusb on Linux shows the correct string.

iInterface 4 Xbox Security Method 3, Version 1.00, © 2005 Microsoft Corporation. All rights reserved.

gdsports avatar Nov 04 '18 23:11 gdsports

Good catch! Two notes:

  1. The length should probably be rewritten as 2 + 88 * 2, matching the other strings.
  2. I didn't realize it was plain text. Wouldn't it make more sense to use the character literals rather than the hex representations?

dmadison avatar Nov 05 '18 06:11 dmadison