pyEPR

pyEPR copied to clipboard

On latest pandas versions, calling `epra.analyze_all_variations` results in the following warnings: ```python c:\pyepr\pyEPR\core_quantum_analysis.py:712: FutureWarning: Support for multi-dimensional indexing (e.g. `obj[:, None]`) is deprecated and will be removed in a future...

nikosavola

This PR adds dtypes to all the empty Pandas Series (there might be some more but these were all the ones used in `do_EPR_analysis`) Closes #107

nikosavola

This resolves the following warnings emerging during EPR analysis ``` pyepr\pyEPR\core_distributed_analysis.py:1307: FutureWarning: The series.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead....

nikosavola

Calling `eprh.hfss_report_full_convergence` sometimes results in _ValueError: Data has no positive values, and therefore can not be log-scaled._ In this case, the simulations did not converge into tight criterion, but behaved...

nikosavola

Running `eprh.do_EPR_analysis()` will result in the following deprecation warning on newest Pandas versions: ``` pyepr\pyEPR\core_distributed_analysis.py:1307: FutureWarning: The series.append method is deprecated and will be removed from pandas in a future...

nikosavola

$global variable as Lj_variable

1

Hi, this is more a question than an issue. According to [this](https://github.com/zlatko-minev/pyEPR/blob/0ac3fa2213d2ef6dacd1d2f487ef345cebee235b/pyEPR/project_info.py#L54) line, it is not recommended to use global variables as Lj_variable. Is this still the case? I didn't...

dmtvanzanten

Sign of junctions will not print correctly

1

Noticed this with the recent fix of the `calc_current_using_line_voltage`, `_Smj` will always return true, need `> 0` to get it to correctly print "(-)" when appropriate. Currently: https://github.com/zlatko-minev/pyEPR/blob/0ac3fa2213d2ef6dacd1d2f487ef345cebee235b/pyEPR/core_distributed_analysis.py#L1028 Should change...

zachparrott

Cache calls to `calc_energy_electric` and `calc_energy_magnetic`

1

`calc_energy_electric` (and `calc_energy_magnetic`) are called in many places in DistributedAnalysis and currently you are supposed to transfer the result of these as a parameter like `U_E` and `U_H` to for...

nikosavola

Empty pandas Series should have `dtype`

1

Currently, I get ``` FutureWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning. Ljs...

nikosavola

This might be for Manu?

zlatko-minev