parking-lanes
parking-lanes copied to clipboard
zlant
iD Editor Link: Use standalone editor
This refactors the iD Editor Link to use the stand alone editor to set more config options via URL params.
The editor function allows to generate an URL based on the map zoom+center or based on a osm object.
My initial goal was to extend this to support custom background layer (so the user sees the same background layer in iD that was selected in this editor before), but this addition requires more changes to the way the background layers are structured; maybe as part of a "allow local layer" refactoring.
Why link to https://ideditor-release.netlify.app instead https://www.openstreetmap.org/edit?editor=id?
Why link to https://ideditor-release.netlify.app/ instead https://www.openstreetmap.org/edit?editor=id?
The stand alone version allows for more customization via URL params and is generally a bit more up to date. ~~But AFAIR right now we don't use the customizations, so we could switch back to the regular version.~~
~~Let me know if this is what is holding the PR back.~~
Update: I double checked, the iD Version on osm.org makes it harder to customize the links to include street level images and such. That is why the stand alone version is the better pick.
@zlant I think this is rebased…
@tordans tordans force-pushed the rework-id-editor-url branch from dff8d79 to 990c8e3 15 minutes ago