LADX-Disassembly icon indicating copy to clipboard operation
LADX-Disassembly copied to clipboard

Renamed Velocity to Speed Fix/#369

Open ealvesss opened this issue 2 years ago • 5 comments

  • it was changed total of 27 files.
  • I'm using vsCode and it was creating a vscode profile folder, so I already added this folder in .gitignore file. Case it is a problem I can Separate the commits.

Check if it fits the spectation and let me know.

😄

(I didn't know which name should use in branch, so I put the number of the issue, hope its ok.)

ealvesss avatar Dec 29 '23 17:12 ealvesss

Thanks for the PR!

As the discussion in the issue suggested, we actually settled on the inverse renaming: renaming everything from Speed to Velocity. The issue title remained the same, and so was misleading; sorry.

So the idea would be to do the inverse renaming (except maybe for cases where the symbol refers to an actual property of an entity, like the constant defining the speed at which it can move. But we just do a bulk rename for now, and catch the remaining tangential cases later).

kemenaran avatar Dec 31 '23 13:12 kemenaran

Oh @kemenaran so I missunderstood! The right way is the oposite! I will fix here then append the commit to the pr.

Sorry about that!

ealvesss avatar Dec 31 '23 15:12 ealvesss

The issue title remained the sa

I've searched in the project and it founded

  • 176 files
    • 2338 occurences

So, as you mentioned above, it would be better to use the "batch rename" approach and fix some specific points that we eventually find in the code.

p.s: I don't know if will be possible solve it today, but I will fix ASAP!

cheers 🎉

ealvesss avatar Dec 31 '23 15:12 ealvesss

@kemenaran fixed it. If I missed something just let me know! By the way, Happy New Year 🎉

ealvesss avatar Dec 31 '23 18:12 ealvesss

OMG a lot of I will change! 😄

I will fix the pointed files ASAP.

Cheers!

ealvesss avatar Jan 08 '24 13:01 ealvesss