Zoltan Kochan

Results 829 comments of Zoltan Kochan

This can be fixed. For now use ``` { // ... "scripts": { "test-node12": "pnpm --config.use-node-version=12.0.0 exec jest", "test-node14": "pnpm --config.use-node-version=14.0.0 exec jest", }, // ... } ```

We are far from merging this anyway. We need to know that mocking modules work with vitest. And there are spies similar to Jest

ok, spies we can test here https://github.com/pnpm/pnpm/blob/main/packages/headless/test/index.ts modules mocks here https://github.com/pnpm/pnpm/blob/3c7e5eced10a443f2d4cd0a79036cf82bbd08bb0/packages/npm-registry-agent/test/index.ts

I tried to switch headless but there is an error ``` RUN v0.18.0 /home/z/src/pnpm/pnpm/packages/headless ❯ test/index.ts (0) ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ FAIL test/index.ts [ test/index.ts ] TypeError: exports.hasOwnProperty is...

I can't, I reverted that code.

No, we cannot use the engines field because if you publish such package and you will install it with `16.14.3`, you'll get a warning. Or even a crash.

Why should pnpm read from `.nvmrc`? pnpm reads settings from `.npmrc`. You can specify the node version via [use-node-version](https://pnpm.io/npmrc#use-node-version) in `.npmrc`. Added an explanation about it to the docs: https://github.com/pnpm/pnpm.github.io/commit/5bd1b5c47f159e9f30f4b652f0f0da17a9575c52

I don't understand this. You probably mean symlinks, not hard links. It is not possible to create a hard link of a directory. And pnpm only creates symlinks for directories,...

But hard links are real files. They are just pointing to the same location on the disk. I don't understand why your file explorer marks those files with some arrows....

Here's a symlinked directory created by pnpm on my Windows machine, looks the same: ![image](https://user-images.githubusercontent.com/1927579/106217906-e9ea1c00-61de-11eb-8705-485939a43fb8.png) I don't understand how you got something that looks like this: ![image](https://user-images.githubusercontent.com/1927579/106217942-fa9a9200-61de-11eb-9bc4-764435469c00.png)