zk-email-verify icon indicating copy to clipboard operation
zk-email-verify copied to clipboard

Revert index range check on SelectRegexReveal

Open saleel opened this issue 1 year ago • 1 comments

Description

Revert index range check on SelectRegexReveal as we go with the principle of no constraining inputs in our utils and leave this to consuming functions.

Type of Change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [ ] I have discussed with the team prior to submitting this PR
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] New and existing unit tests pass locally with my changes

saleel avatar Sep 08 '24 16:09 saleel

I have reverted prettier file changes from this PR. We can do yarn lint on main once all the PRs are merged to avoid conflicts. Should be good to merge now @Divide-By-0

saleel avatar Oct 01 '24 09:10 saleel