email-recovery icon indicating copy to clipboard operation
email-recovery copied to clipboard

Feat/test improvements

Open JohnGuilding opened this issue 5 months ago • 0 comments

This PR:

  • Extracts duplicate logic from tests into fewer base tests. As opposed from having many base tests with the same logic
  • Renames some stuff
  • Fixes a load of compile warnings

Might be a difficult one to review without good context on how the tests are structured. Would try:

  1. Verify the assertions haven't fundamentally changed. Most of the changes in the test files themselves are just renames or some sort/changing parameters passed into test helper functions
  2. Focus on Base test files.
    • That Base.t.sol has everything you would expect
    • Review use of computeEmailAuthAddress as that is a virtual function in Base.t.sol and is implemented in other base tests
    • Review use of deployModule as that is a virtual function in Base.t.sol and is implemented in other base tests

There is still some work to be done here, for example abstracting away handleRecovery helper functions into fewer base test files. That will be covered in a future PR that can be merged on top of the audit fixes

JohnGuilding avatar Sep 18 '24 20:09 JohnGuilding