zk-kit.circom icon indicating copy to clipboard operation
zk-kit.circom copied to clipboard

fix: range check constrain in `float.circom`

Open Vishalkulkarni45 opened this issue 10 months ago • 0 comments

Description

  • Fixed the range check implementation of IntegerDivision and MultiplicationFromFloat
  • Replaced assert(lt == 1) with lt === 1 constrain
  • Replaced assert(isz == 0) with lsz === 0 constrain

Related Issue(s)

#13

Other information

Checklist

  • [x] I have read and understand the contributor guidelines and code of conduct.
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I have run yarn style without getting any errors
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

[!IMPORTANT] We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.

Vishalkulkarni45 avatar Feb 22 '25 11:02 Vishalkulkarni45