clean-pvnet icon indicating copy to clipboard operation
clean-pvnet copied to clipboard

Update RANSAC Voting for PyTorch (>1.10) & CUDA (>11.1) Compatibility

Open Divyam10 opened this issue 1 year ago โ€ข 0 comments

โ„น๏ธ Ensure Compatibility with Newer PyTorch and CUDA Versions for RANSAC Voting Layer

๐Ÿš€ Summary: This commit updates the RANSAC voting module to ensure compatibility with the latest PyTorch and CUDA versions.

๐Ÿ”„ Changes Made:

  • Pytorch has removed Thc/thc.h headers from version >11.1 which gives compilation errors. Commented extern THCState* state; in ransac_voting.cpp
  • Replaced the torch.solve() with torch.linalg.solve() for newer version.
  • Applied tensor.ge() function on the mask as tensor.masked_select expects a boolean tensor array in newer versions.

๐Ÿ“‹ Additional Notes:

  • Requirements.txt should be updated to work with newer versions as well.

๐Ÿ”ง Dependencies:

  • PyTorch: >1.11
  • CUDA: >11.1

๐Ÿงช Testing:

  • Ran comprehensive tests to validate the compatibility with PyTorch [2.1.2] and CUDA [11.8].
  • Verified that the RANSAC voting module performs as expected.

๐Ÿ‘ Acknowledgments: Thanks to the authors for sharing code for this valuable research.

๐Ÿ“… Date: 21st Jan, 2024

Divyam10 avatar Jan 21 '24 08:01 Divyam10