OnePose icon indicating copy to clipboard operation
OnePose copied to clipboard

Redundent module

Open RPFey opened this issue 2 years ago • 0 comments

Thank you for releasing your great work!

When I browse your code, I find that some module is defined but not used in the forward pass, for example: in here

self.kenc_2d = KeypointEncoder(
                        inp_dim=3,
                        feature_dim=hparams['descriptor_dim'],
                        layers=hparams['keypoints_encoder']
                    )

The module self.kenc_2d is defined here but it is not used in the forward pass. (I search this name in the whole project and only find one result. )

I suppose you want to use the position embedding but finally give up.

Why don't you use the position embedding module? Do you forget or this module harms the performance?

RPFey avatar Feb 02 '23 06:02 RPFey