vscode-ag icon indicating copy to clipboard operation
vscode-ag copied to clipboard

No search panel

Open Avery-Whitaker opened this issue 5 years ago • 7 comments

I am not seeing any search panel at all when I do a search. Does this extension work?

Avery-Whitaker avatar Oct 29 '19 19:10 Avery-Whitaker

Because of an update of vscode, vscode.previewHtml API has removed. So, this extension, which relies on this API, does not work anymore.

I made a pull request to fix that. (#23)

kamocyc avatar Nov 30 '19 04:11 kamocyc

Why hasn't it been merged? Without search panel, vscode-ag totally cann't be used.

lyjdwh avatar Mar 17 '20 05:03 lyjdwh

I was really keen to give this a shot, but unfortunately it's not working. Can you please merge, or alternatively @kamocyc could you publish your own version please?

Xaraxia avatar Jul 03 '20 06:07 Xaraxia

@zjhmale Can you please merge #23?

kschwarz1116 avatar Jul 13 '20 19:07 kschwarz1116

I built the fork that was never merged in (thanks @kamocyc) https://github.com/kamocyc/vscode-ag/tree/develop and replaced the package.json depenency section with more up to date versions.

  "devDependencies": {
    "@types/clipboard": "^2.0.1",
    "@types/glob": "^7.1.3",
    "@types/he": "^1.1.1",
    "@types/jquery": "^3.5.5",
    "@types/lodash": "^4.14.168",
    "@types/mocha": "^8.0.4",
    "@types/node": "^12.11.7",
    "@types/vscode": "^1.39.0",
    "@typescript-eslint/eslint-plugin": "^4.14.1",
    "@typescript-eslint/parser": "^4.14.1",
    "eslint": "^7.19.0",
    "glob": "^7.1.6",
    "mocha": "^8.2.1",
    "typescript": "^4.1.3",
    "vscode-test": "^1.5.0"
  },
  "dependencies": {
    "he": "^1.2.0",
    "jquery": "^3.6.0",
    "lodash": "^4.17.21",
    "normalize.css": "^8.0.1"
  }

and managed to get this extension running. Attached is the vscode-ag-0.3.2.vsix so that people can install manually.

I could potentially take over this extension and publish it properly - since its essentially abandoned. However the current UI needs some fixes - the list of results isn't pretty IMO and when you hover over each result there is a jumping effect as the 'AG Detail' opens then closes as the mouse moves away. Plus the project itself seems to prevent me closing the project, I have to force quit vscode on mac to get out of it - weird.

Running ag in the terminal of vscode is currently a better experience! There is another ag related plugin called vscode-quick-search which has a prettier tree but its really flaky for me, rarely finding anything reliably.

vscode-ag-0.3.2.vsix.zip Screen Shot 2021-03-27 at 6 17 43 pm

abulka avatar Mar 27 '21 07:03 abulka

@abulka anything you are waiting for? If the original developer hasn't reacted in the last half year, it's unlikely he ever will.

dwt avatar Jan 27 '22 08:01 dwt

@all also there is https://github.com/doiken/vscode-quick-search as an alternative

dwt avatar Jan 27 '22 08:01 dwt