zixpo
Motorola Launcher Not Supported on All Models
Follow-up from #172 and its PR #174
In short: I can't confirm that Moto Launcher recognises icon packs on any of the devices I've tested and we need to refine the logic that shows Moto as supported in Candybar.
The original PR says it was tested on a Moto G Stylus 2023. I sadly don't have access to this particular device. It seems it can run Android 14, so I went to check these two devices I have access to via Lambdatest (real device testing):
- Moto g54 5G (XT2343-5) Android 14
- Moto g22 (XT2231-2) Android 12
This is what shows up in the errors logs:
07-08 09:52:46.920 1903 3554 I ActivityTaskManager: START u0 {act=android.intent.action.MAIN flg=0x10000000 cmp=com.motorola.launcher3/com.motorola.personalize.app.IconPacksActivity} with LAUNCH_MULTIPLE from uid 18805 (startActivityAsUser) result code=-92
07-08 09:52:46.926 4551 4551 E TutorialKt$Tutorial$7$4$2$1$8$openLauncherSettings: Failed to open settings activity
07-08 09:52:46.926 4551 4551 E TutorialKt$Tutorial$7$4$2$1$8$openLauncherSettings: android.content.ActivityNotFoundException: Unable to find explicit activity class {com.motorola.launcher3/com.motorola.personalize.app.IconPacksActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?
Does it only work on Chinese ROMs? Do we have a way to recognise them? If not, should we test that com.motorola.launcher3/com.motorola.personalize.app.IconPacksActivity resolves on the device before we show it as supported?
@maxtron95 as you implemented this, your input would be much appreciated. Each day I get bug reports from Motorola users. My user base is mostly EU/US.
check this commit last time i checked with this commit it "worked" (icon packs show only if they are adaptive)
No success with that commit, sadly. On the g22 device with Android 12, com.motorola.personalize/com.motorola.personalize.app.IconPacksActivity doesn't resolve. On the g54 with Android 14 it does resolve but can't be launched.
weird, for me candybar dev is showing with that commit, just checked with a motorola edge 40 emulator.
Dumb i know but it seems is not working if you just put <item>moto</item>, try with <item>moto_launcher</item>
on the g22 do you have any means to get the package name? might be different there
@GitGitro indeed, I can confirm that the <item>moto</item> entry is wrong. 😑 I sneaked that fix in with my existing PR https://github.com/zixpo/candybar/pull/216/commits/7b64c00cad20782472735c23afaf516775acb4d6
With that set, the activity does show and launch on the g54 with Android 14 no problem. Still no luck on the g22 device with Android 12. I installed "QuickShortcutMaker" and looked through all Moto-related activities but there's nothing addressing icons in any way. Maybe it's just not available on Android 12 and below?
Some more insights regarding Moto: We might not even want to enable it by default. 🤔 It only works with vector icons (e.g. raster icons like Delta, Lawnicons and Arcticons will show up in the overview on the g54 device but applying them does nothing. Arcticons Material You does work. FYI @Donnnno).
Yeah I'm aware that the material version works. From what I understand the icons have to be adaptive but not necessarily vector. I could be wrong tho
You're right! Adaptive works. I'm just unhappy that the default result is entirely empty (and can't be applied either). This is what I see in Moto Launcher:
Non-adaptive icon packs should not include <item>moto_launcher</item> and should not include an icon_config.xml. IMHO the least we can do is to remove moto_launcher from the default launchers.xml in CandyBar and add a warning in the comments that icon_config.xml should only be generated if the icons are adaptive.